Skip to content

Fix spelling/grammar for OOA_4J17 description#1806

Merged
petrelharp merged 2 commits intopopsim-consortium:mainfrom
hyanwong:patch-9
Mar 5, 2026
Merged

Fix spelling/grammar for OOA_4J17 description#1806
petrelharp merged 2 commits intopopsim-consortium:mainfrom
hyanwong:patch-9

Conversation

@hyanwong
Copy link
Contributor

@hyanwong hyanwong commented Mar 3, 2026

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.81%. Comparing base (ae81ee8) to head (cc94430).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         142      142           
  Lines        4873     4873           
  Branches      472      472           
=======================================
  Hits         4864     4864           
  Misses          6        6           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petrelharp
Copy link
Contributor

:1: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.

@petrelharp
Copy link
Contributor

I adjusted the wording a bit, but this error was there before. I cannot tell what is wrong here?

@hyanwong
Copy link
Contributor Author

hyanwong commented Mar 4, 2026

Neither can I. Builds are failing because of pyslim latest docs failing, which I suspect is because of Jerome rationalising the build process. We can wait until that's done in a week or so before checking for merging.

@petrelharp
Copy link
Contributor

Ah okay - you think that's why they're failing? I thought it might be the other thing, but agreed we can wait. (However, this shouldn't be pulling the dev pyslim, it should be pulling stable pyslim?!?!)

@hyanwong
Copy link
Contributor Author

hyanwong commented Mar 4, 2026

Well, that's one of the warnings, but maybe not the failing one. If it;s meant to be the stable version, I guess we can easily fix that, regardless.

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://tskit.dev/pyslim/docs/latest/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for url: https://tskit.dev/pyslim/docs/latest/objects.inv

@petrelharp
Copy link
Contributor

Now this needs to be rebased.

@hyanwong
Copy link
Contributor Author

hyanwong commented Mar 5, 2026

I rebased now. ready to merge.

@petrelharp petrelharp merged commit e23d255 into popsim-consortium:main Mar 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants